chore: pipe words to memory instead of manual adv_loadw
#2273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+30
to
+31
| push.LEAF_DATA_START_PTR push.LEAF_DATA_NUM_WORDS | ||
| exec.mem::pipe_words_to_memory dropw dropw dropw drop |
Contributor
There was a problem hiding this comment.
This function looks great! I added some stack comments, I think it should look like this:
pub proc get_leaf_value
adv.push_mapval dropw
# => [LEAF_DATA_KEY]
push.LEAF_DATA_START_PTR push.LEAF_DATA_NUM_WORDS
exec.mem::pipe_words_to_memory dropw dropw dropw drop
# => []
push.LEAF_DATA_BYTES push.LEAF_DATA_START_PTR
# => [start_ptr, byte_len]
exec.keccak256::hash_bytes
# => [LEAF_VALUE[8]]
# truncate stack
swapdw dropw dropw
# => [LEAF_VALUE[8]]
end
partylikeits1983
approved these changes
Jan 14, 2026
Contributor
partylikeits1983
left a comment
partylikeits1983
left a comment
There was a problem hiding this comment.
This is great! My implementation was a bit complex, this is much better :)
partylikeits1983
merged commit f9f2d57
into
0xMiden:ajl-agglayer-get-leaf-value
15 of 16 checks passed
bobbinth
reviewed
Jan 15, 2026
mmagician
added
the
no changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses
pipe_words_to_memory, but first ensures padding up to a number of felts divisible by 4.This should be merged only after #2262 (comment) is addressed and we verify that this code still returns the expected value (it should!)